Simplify TRUSTED_PROXIES and TRUSTED_HOSTS config #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe using `getenv` provides a simpler way to extract the variable, avoiding the `isset` ternary. `getenv` is case insensitive
|
I don't know- where are those env variables set? |
|
getenv() and $_SERVER behave the same way, the only difference is that getenv() is case-insensitive. In the Symfony Bootstrap we already used getenv() previously hence the PR to keep it coherent. |
|
To be clear, this is not a bug fix, is just a simpler version of the same lines using getenv() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe using
getenvprovides a simpler way to extract the variable, avoiding theissetternary.getenvis case insensitive